Refactor codebase, also removing some features #14
Conversation
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
| }, | ||
| } | ||
|
|
||
| type Encoder interface { |
There was a problem hiding this comment.
exported type Encoder should have comment or be unexported
| } | ||
|
|
||
| func init() { | ||
| rootCmd.AddCommand(versionCmd) | ||
| func (e *Encoder) Encode(set []onf.ONF) error { |
There was a problem hiding this comment.
exported method Encoder.Encode should have comment or be unexported
| Run: func(cmd *cobra.Command, args []string) { | ||
| fmt.Printf("Version: %s, Commit: %s, Built at: %s\n\n", Version, Commit, BuildTime) | ||
| }, | ||
| func NewEncoder(w io.Writer) *Encoder { |
There was a problem hiding this comment.
exported function NewEncoder should have comment or be unexported
| Commit = "N/A" | ||
| BuildTime = "N/A" | ||
| ) | ||
| type Encoder struct { |
There was a problem hiding this comment.
exported type Encoder should have comment or be unexported
| Pid int | ||
| } | ||
|
|
||
| func Run() ([]ActiveConnection, error) { |
There was a problem hiding this comment.
exported function Run should have comment or be unexported
| "gopkg.in/pipe.v2" | ||
| ) | ||
|
|
||
| type ActiveConnection struct { |
There was a problem hiding this comment.
exported type ActiveConnection should have comment or be unexported
| DstAddr net.Addr // Destination address | ||
| } | ||
|
|
||
| func Run() ([]OpenFile, error) { |
There was a problem hiding this comment.
exported function Run should have comment or be unexported
| "gopkg.in/pipe.v2" | ||
| ) | ||
|
|
||
| type OpenFile struct { |
There was a problem hiding this comment.
exported type OpenFile should have comment or be unexported
| return scanner.Err() | ||
| } | ||
|
|
||
| func ParseNetAddr(network, addr string) (net.Addr, error) { |
There was a problem hiding this comment.
exported function ParseNetAddr should have comment or be unexported
| "strings" | ||
| ) | ||
|
|
||
| func ChunkLine(line string, sep string, min int) ([]string, error) { |
There was a problem hiding this comment.
exported function ChunkLine should have comment or be unexported
| }, | ||
| } | ||
|
|
||
| type Encoder interface { |
There was a problem hiding this comment.
exported type Encoder should have comment or be unexported
| } | ||
|
|
||
| func init() { | ||
| rootCmd.AddCommand(versionCmd) | ||
| func (e *Encoder) Encode(set []onf.ONF) error { |
There was a problem hiding this comment.
exported method Encoder.Encode should have comment or be unexported
| Run: func(cmd *cobra.Command, args []string) { | ||
| fmt.Printf("Version: %s, Commit: %s, Built at: %s\n\n", Version, Commit, BuildTime) | ||
| }, | ||
| func NewEncoder(w io.Writer) *Encoder { |
There was a problem hiding this comment.
exported function NewEncoder should have comment or be unexported
| Commit = "N/A" | ||
| BuildTime = "N/A" | ||
| ) | ||
| type Encoder struct { |
There was a problem hiding this comment.
exported type Encoder should have comment or be unexported
The dynamic build of the filtering regular expression based on user input was removed, as it is not so useful in practise. From now on the user is expected to provide the raw regex by himself.
This merge has an incompatible API compared with the previous version of the library.